Skip to content

Mark a whole server as read (mark-as-unread shipped with 0.2.x) - #899

Closed
unRekable wants to merge 1 commit into
mainfrom
draft/775-unread-marks
Closed

unRekable wants to merge 1 commit into
mainfrom
draft/775-unread-marks

Conversation

@unRekable

Copy link
Copy Markdown
Collaborator

What changed and why

"Mark as read" on a Space's menu: Request::MarkAllRead grows a space field, chatd names
only that Space's badge rows, Discord hears its bulk acks for just those channels, and other
Spaces and direct messages keep their badges. This is the second half of #775; the first
half (mark a conversation as unread) shipped in #882, and a store test here pins its rule
that a stale network count cannot undo a local unread.

Type

  • feature
  • fix
  • perf
  • refactor
  • chore
  • docs

Platforms

  • windows
  • macos
  • linux
  • android
  • ios

Proof

Scenario: e2e/scenarios/space-mark-all-read

Lab run:

Compatibility

Request::MarkAllRead gains space: Option<Key>, #[serde(default, skip_serializing_if = "Option::is_none")], left off the wire when unset — a frame from this build and from an
older build are the same bytes when no Space is named. An older chatd ignores the unknown
field and answers the wider request (the whole network), which is only reachable across a
mid-update mix of the same release train. Nothing is renamed or removed; no variant added.

Risk and rollback

Wrong Space scoping could clear more badges than asked; the Discord integration test pins the
other Space and the direct rows keeping theirs, and the store query is the only new
selection logic. Rollback: revert the commit — the field disappears from the wire and the
menu item with it. Per-network note kept honest: with read receipts off, the network is not
told, so its badges return on the next sync, exactly as a network-wide mark behaves today.

Release note

Mark everything read in one server at a time from its menu.

@unRekable

Copy link
Copy Markdown
Collaborator Author

Note on the red ios (libs + unsigned archive) check: the job never ran — the runner annotations say The job was not acquired by Runner of type hosted even after multiple attempts / Due to capacity constraints, jobs targeting macOS arm64 runners may experience longer queue times. Same documented hosted-runner capacity problem as on #897 (docs/quality-gate.md records it for test (macos-latest)), not this diff: every check that executed is green (all ubuntu shards, android, doc tests + mobile check, pr-gate), and the diff touches desktop chatd/window code plus a mobile-gated module — nothing iOS links differently.

@itz4blitz
itz4blitz marked this pull request as ready for review November 20, 2026 19:59
@itz4blitz
itz4blitz self-requested a review as a code owner November 20, 2026 19:59
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Tiny Code Review

⚠️ Code review unavailable · run

the AI provider rate-limited the request

This is advice, not a gate. Re-run with the agent:review label or a /review comment.

@itz4blitz

Copy link
Copy Markdown
Collaborator

Superseded by and merged in #903 (d387971 — Release 2026-11-20 combined PR).

@itz4blitz itz4blitz closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants