You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Mark a whole server as read (mark-as-unread shipped with 0.2.x) - #899
"Mark as read" on a Space's menu: Request::MarkAllRead grows a space field, chatd names
only that Space's badge rows, Discord hears its bulk acks for just those channels, and other
Spaces and direct messages keep their badges. This is the second half of #775; the first
half (mark a conversation as unread) shipped in #882, and a store test here pins its rule
that a stale network count cannot undo a local unread.
Type
feature
fix
perf
refactor
chore
docs
Platforms
windows
macos
linux
android
ios
Proof
Scenario: e2e/scenarios/space-mark-all-read
Lab run:
Compatibility
Request::MarkAllRead gains space: Option<Key>, #[serde(default, skip_serializing_if = "Option::is_none")], left off the wire when unset — a frame from this build and from an
older build are the same bytes when no Space is named. An older chatd ignores the unknown
field and answers the wider request (the whole network), which is only reachable across a
mid-update mix of the same release train. Nothing is renamed or removed; no variant added.
Risk and rollback
Wrong Space scoping could clear more badges than asked; the Discord integration test pins the
other Space and the direct rows keeping theirs, and the store query is the only new
selection logic. Rollback: revert the commit — the field disappears from the wire and the
menu item with it. Per-network note kept honest: with read receipts off, the network is not
told, so its badges return on the next sync, exactly as a network-wide mark behaves today.
Release note
Mark everything read in one server at a time from its menu.
Note on the red ios (libs + unsigned archive) check: the job never ran — the runner annotations say The job was not acquired by Runner of type hosted even after multiple attempts / Due to capacity constraints, jobs targeting macOS arm64 runners may experience longer queue times. Same documented hosted-runner capacity problem as on #897 (docs/quality-gate.md records it for test (macos-latest)), not this diff: every check that executed is green (all ubuntu shards, android, doc tests + mobile check, pr-gate), and the diff touches desktop chatd/window code plus a mobile-gated module — nothing iOS links differently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
"Mark as read" on a Space's menu:
Request::MarkAllReadgrows aspacefield, chatd namesonly that Space's badge rows, Discord hears its bulk acks for just those channels, and other
Spaces and direct messages keep their badges. This is the second half of #775; the first
half (mark a conversation as unread) shipped in #882, and a store test here pins its rule
that a stale network count cannot undo a local unread.
Type
Platforms
Proof
Scenario: e2e/scenarios/space-mark-all-read
Lab run:
Compatibility
Request::MarkAllReadgainsspace: Option<Key>,#[serde(default, skip_serializing_if = "Option::is_none")], left off the wire when unset — a frame from this build and from anolder build are the same bytes when no Space is named. An older chatd ignores the unknown
field and answers the wider request (the whole network), which is only reachable across a
mid-update mix of the same release train. Nothing is renamed or removed; no variant added.
Risk and rollback
Wrong Space scoping could clear more badges than asked; the Discord integration test pins the
other Space and the direct rows keeping theirs, and the store query is the only new
selection logic. Rollback: revert the commit — the field disappears from the wire and the
menu item with it. Per-network note kept honest: with read receipts off, the network is not
told, so its badges return on the next sync, exactly as a network-wide mark behaves today.
Release note
Mark everything read in one server at a time from its menu.